You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
WITH inserted AS (
INSERT INTO x (foo)
SELECT bar FROM b
RETURNING y
)
SELECT y
FROM inserted;
The current version of the parser fails when faced with these statements as only ParenthesedSelects are allowed to appear within CTEs
Solution
Change the WithItem class so that...
WithItem no longer extends ParenthesedSelect
Instead WithItem has type T where T extends the new interface ParenthesedStatement
ParenthesedSelect implements ParenthesedStatement
New classes ParenthesedInsert + ParenthesedUpdate + ParenthesedDelete are also implementations ParenthesedStatement
Notes
I could definitely do with some feedback on the approach Ive taken here.
I've done my best to avoid impacting any existing functionality. The method getWithItemsList in various classes now returns a List<WithItem<?>> object rather than a List<WithItem> object. I think this should be the most "disruptive" thing I've included.
Impressive contribution, thank you already for your time and effort!
Please give me a time to digest and appreciate everything properly. We will definitely merge this eventually!
Clean, I really do like your work! Thank you again.
Please do me 2 favors though:
fix the Codacy exceptions
for the 2 failing Gradle performance tests, please reduce the number of loops from 10 to 6 (temporarily, there is a pending PR which fixes this properly)
for the 2 failing Gradle performance tests, please reduce the number of loops from 10 to 6 (temporarily, there is a pending PR which fixes this properly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Postgres it is valid syntax to have insert, update or delete statements appear within CTEs.
See here on https://www.postgresql.org/docs/current/sql-select.html
e.g.
The current version of the parser fails when faced with these statements as only
ParenthesedSelects are allowed to appear within CTEsSolution
Change the
WithItemclass so that...WithItemno longer extendsParenthesedSelectWithItemhas type T where T extends the new interfaceParenthesedStatementParenthesedSelectimplementsParenthesedStatementParenthesedInsert+ParenthesedUpdate+ParenthesedDeleteare also implementationsParenthesedStatementNotes
I could definitely do with some feedback on the approach Ive taken here.
I've done my best to avoid impacting any existing functionality. The method
getWithItemsListin various classes now returns aList<WithItem<?>>object rather than aList<WithItem>object. I think this should be the most "disruptive" thing I've included.