feat: hide FloatWindow when all events deprecated and update ActivityTicker links#248
Conversation
…Ticker links Co-authored-by: longsizhuo <114939201+longsizhuo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Modified
app/components/float-window/FloatWindow.tsxto hide the component if the latest event is deprecated (which implies all events are deprecated due to sorting).Modified
app/components/ActivityTicker.tsxto use theplaybackURL or a fallback URL (https://involutionhell.com/docs/jobs/event-keynote/event-takeway) when an event is deprecated, instead of the Discord URL.Verified logic with a temporary unit test and ran existing tests to ensure no regressions.
Linted and type-checked the changes.
PR created automatically by Jules for task 6939529083496794611 started by @longsizhuo