This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Changing csv_reader_py impl to return df from objmode #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-07 22:18:36 UTC |
Motivation: returning Tuple of columns read from csv file with pyarrow csv reader from objmode and further calling init_dataframe ctor to create native DF turned out to be inneficient in sense of LLVM IR size and compilation time. With this PR we now rely on DF unboxing and return py DF from objmode.
a275fc6 to
964e498
Compare
Hardcode84
reviewed
Aug 31, 2020
87fdabe to
2b8b003
Compare
kozlov-alexey
commented
Sep 7, 2020
| tuple(col_typs), | ||
| types.none, | ||
| tuple(col_names), | ||
| column_loc=column_loc |
Contributor
Author
There was a problem hiding this comment.
This implies has_parent=False (so we won't make reflection of changes made to native DF at boxing to python object), but it turns out that we don't support reflection for DFs at all. @AlexanderKalistratov, do you think it's a problem in this context (i.e. we should probably support reflection first)?
kozlov-alexey
commented
Sep 7, 2020
AlexanderKalistratov
approved these changes
Sep 9, 2020
Hardcode84
added a commit
that referenced
this pull request
Sep 30, 2020
This reverts commit 811e9f0.
Hardcode84
pushed a commit
that referenced
this pull request
Sep 30, 2020
kozlov-alexey
added a commit
to kozlov-alexey/sdc
that referenced
this pull request
Nov 3, 2020
This reverts commit 30122b2.
kozlov-alexey
added a commit
to kozlov-alexey/sdc
that referenced
this pull request
Nov 6, 2020
This reverts commit 30122b2.
kozlov-alexey
added a commit
to kozlov-alexey/sdc
that referenced
this pull request
Nov 9, 2020
This reverts commit 30122b2.
kozlov-alexey
added a commit
that referenced
this pull request
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: returning Tuple of columns read from csv file with
pyarrow csv reader from objmode and further calling init_dataframe
ctor to create native DF turned out to be inefficient in sense of
LLVM IR size and compilation time. With this PR we now rely on DF
unboxing and return py DF from objmode.
Compile time of read_csv + df.count():