Skip to content

Extend build_locally.py with --target-cuda and --target-hip arguments #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlad-perevezentsev merged 7 commits into from
Aug 1, 2025
Merged

Extend build_locally.py with --target-cuda and --target-hip arguments #2109

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6c33b40
Extend build_locally.py with --target-cuda to simplify passing CUDA t…
vlad-perevezentsev Jun 20, 2025
cfa26fb
Update docs to reflect new --target-cuda option
vlad-perevezentsev Jun 20, 2025
ef6025e
Extend build_locally.py with --target-hip to simplify passing HIP target
vlad-perevezentsev Jun 20, 2025
3bf2bbc
Update docs to reflect new --target-hip option
vlad-perevezentsev Jun 20, 2025
4e250d6
Document CMake option usage as alternative to --target-cuda/--target-hip
vlad-perevezentsev Jun 25, 2025
00ce83c
Merge remote-tracking branch 'origin' into add_targets_args
vlad-perevezentsev Jul 28, 2025
f0c7c42
Add validation --target-cuda/--target-hip to avoid ambiguity with CMa…
vlad-perevezentsev Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add validation --target-cuda/--target-hip to avoid ambiguity with CMa… 
…ke options
  • Loading branch information
@vlad-perevezentsev
vlad-perevezentsev committed Jul 28, 2025
commit f0c7c427ab9e7522ef103553f25a3abd31f3a3f6
12 changes: 12 additions & 0 deletions scripts/build_locally.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ def run(
"--target-cuda can not be an empty string. "
"Use --target-cuda=<arch> or --target-cuda"
)
if any(opt.startswith("-DDPCTL_TARGET_CUDA=") for opt in cmake_args):
raise ValueError(
"Both --target-cuda and -DDPCTL_TARGET_CUDA in --cmake-opts "
"were specified. Please use only one method "
"to avoid ambiguity"
)
cmake_args += [
f"-DDPCTL_TARGET_CUDA={target_cuda}",
]
Comment thread
ndgrigorian marked this conversation as resolved.
Expand All @@ -81,6 +87,12 @@ def run(
raise ValueError(
"--target-hip requires an architecture (e.g., gfx90a)"
)
if any(opt.startswith("-DDPCTL_TARGET_HIP=") for opt in cmake_args):
raise ValueError(
"Both --target-hip and -DDPCTL_TARGET_HIP in --cmake-opts "
"were specified. Please use only one method "
"to avoid ambiguity"
)
cmake_args += [
f"-DDPCTL_TARGET_HIP={target_hip}",
]
Expand Down
Loading