Align to np2 py312#1763
Merged
oleksandr-pavlyk merged 3 commits intobuild-with-numpy-2.0from Jul 28, 2024
Merged
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_175 ran successfully. |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_176 ran successfully. |
Introduced default_device_uint_type, parallel to
default_device_int_type.
For NumPy >= 2 (as checked at runtime), it returns "i8" (since dpctl
is only supported on x86_64) or unsigned "u8", while for NumPy < 2 it
returns long ("l"), or 'unsigned long' ("L").
…integral type with call to uint query
19e4aa0 to
00ecabe
Compare
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_171 ran successfully. |
antonwolfy
approved these changes
Jul 28, 2024
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
There is no impact on DPNP, all tests pass. And the code changes looks good to me.
Thank you @oleksandr-pavlyk
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to fix
dpctlto pass test suite with NumPy 2.0 on Windows.