You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The process for merging changes to the translations is a bit complicated right now.
In short:
merge the changes into main
then merge main into the respective book branch e.g. book-zh
With this approach we make sure that the latest version of the content is visible in main, and contributors are acknowledged correctly.
At the same time we allow contributors to hit the "Edit on GitHub" button in the translated gitbooks, in order to make small typo changes. We as maintainers then have to change the target branching to main before merging the change but that seems manageable.
I thought I had written up somewhere why we do it this way but I cannot find that right now.
spier
changed the title
Fixed the formate typo of the README.md
[Chinese translation] Fixed format typo of README.md
Jan 16, 2023
@spier I just submitted the PR through the "Edit on GitHub" on the Gitbook page.
Can we set up a GitHub Action to cherry-pick the patch into gitbook-zh branch?
One other issue that we ran into with our current approach: book-zh is a protected branch, so some automations with GitHub action were failing, as the bot users that are executing the GitHub action did not have the permission to commit to the branch or something similar.
Just so you know:
I am not super happy with how maintaining the translations works in gitbook. That's why I am looking at alternatives to gitbook right now. However this will take a bit longer, as I haven't found a simple solution yet, even when using other tools like mkdocs etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.