Skip to content

fixes clicking on non-nested item on mobile - #2462

Open
bestcatarina wants to merge 6 commits into
masterfrom
2461-navbar-when-click-on-item-in-mobile-sidebar-sidebar-should-close
Open

fixes clicking on non-nested item on mobile#2462
bestcatarina wants to merge 6 commits into
masterfrom
2461-navbar-when-click-on-item-in-mobile-sidebar-sidebar-should-close

Conversation

@bestcatarina

@bestcatarina bestcatarina commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
When on mobile, clicking on an item without nested items closes the navbar and sidebar.

Reference:
#2461

📦 Published PR as canary version: 39.45.1--canary.2462.31782687641.0

✨ Test out this PR locally via:

npm install example-generator@39.45.1--canary.2462.31782687641.0
npm install angular-module-example@39.45.1--canary.2462.31782687641.0
npm install angular-standalone-example@39.45.1--canary.2462.31782687641.0
npm install html-cdn-example@39.45.1--canary.2462.31782687641.0
npm install html-vite-example@39.45.1--canary.2462.31782687641.0
npm install react-example@39.45.1--canary.2462.31782687641.0
npm install vue-example@39.45.1--canary.2462.31782687641.0
npm install @infineon/infineon-design-system-stencil@39.45.1--canary.2462.31782687641.0
npm install @infineon/dds-tooling@39.45.1--canary.2462.31782687641.0
npm install @infineon/design-system-mcp@39.45.1--canary.2462.31782687641.0
npm install @infineon/infineon-design-system-angular@39.45.1--canary.2462.31782687641.0
npm install @infineon/infineon-design-system-react@39.45.1--canary.2462.31782687641.0
npm install @infineon/infineon-design-system-vue@39.45.1--canary.2462.31782687641.0
# or 
yarn add example-generator@39.45.1--canary.2462.31782687641.0
yarn add angular-module-example@39.45.1--canary.2462.31782687641.0
yarn add angular-standalone-example@39.45.1--canary.2462.31782687641.0
yarn add html-cdn-example@39.45.1--canary.2462.31782687641.0
yarn add html-vite-example@39.45.1--canary.2462.31782687641.0
yarn add react-example@39.45.1--canary.2462.31782687641.0
yarn add vue-example@39.45.1--canary.2462.31782687641.0
yarn add @infineon/infineon-design-system-stencil@39.45.1--canary.2462.31782687641.0
yarn add @infineon/dds-tooling@39.45.1--canary.2462.31782687641.0
yarn add @infineon/design-system-mcp@39.45.1--canary.2462.31782687641.0
yarn add @infineon/infineon-design-system-angular@39.45.1--canary.2462.31782687641.0
yarn add @infineon/infineon-design-system-react@39.45.1--canary.2462.31782687641.0
yarn add @infineon/infineon-design-system-vue@39.45.1--canary.2462.31782687641.0

@bestcatarina bestcatarina added minor minor version bump patch patch version bump and removed minor minor version bump labels Aug 12, 2026
@bestcatarina
bestcatarina marked this pull request as draft August 12, 2026 10:47
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Storybook Preview

Preview Links for Deployed Examples

Version: 39.45.1--canary.2462.31782687641.0

@bestcatarina
bestcatarina marked this pull request as ready for review August 13, 2026 10:12
@bestcatarina
bestcatarina marked this pull request as draft August 13, 2026 10:25
@bestcatarina
bestcatarina marked this pull request as ready for review August 14, 2026 08:44
@tishoyanchev

Copy link
Copy Markdown
Contributor

@bestcatarina
Only works for first layer items. Clicking on nested item doesn't collapse the sidebar

@tishoyanchev

Copy link
Copy Markdown
Contributor

@bestcatarina
The new collapse logic on sidebar collapses the sidebar on click of an item, but it doesn't add the 'collapsible' button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navbar: when click on item in mobile sidebar, sidebar should close

2 participants