Repository navigation
Cleanup architecture detection and atomics support - #11083
Open
jschmidt-icinga wants to merge 1 commit into
Open
jschmidt-icinga wants to merge 1 commit into
jschmidt-icinga wants to merge 1 commit into
Conversation
Most of this wasn't used anywhere except for determining atomics support. There was even a (severely broken) `check_cxx_source_compiles` snippet already in place, which is what you are supposed to do to detect if atomics support requires a library independently of the processor architecture. This fixes the snippet and uses it for a proper check to determine support, with and without library. This also removes an obsolete check if the override keyword is supported on MSVC.
Al2Klimov
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of this wasn't used anywhere except for determining atomics support. There was even a (severely broken)
check_cxx_source_compilessnippet already in place, which is what you are supposed to do to detect if atomics support requires a library (instead of comparing with an architecture string).This fixes the snippet and uses it for a proper check to determine support, with and without library.
This also removes an obsolete check if the override keyword is supported on MSVC.
This has been split off from #10936 to make the full PR a bit smaller and easier to review.