Repository navigation
ssl_cert: Allow forcing IPv4 or IPv6 - #11012
Open
IshanA2007 wants to merge 1 commit into
Open
IshanA2007 wants to merge 1 commit into
IshanA2007 wants to merge 1 commit into
Conversation
The check_ssl_cert plugin supports -4/-6 to force IPv4 or IPv6, but the ssl_cert CheckCommand had no way to pass them, unlike most other CheckCommands that wrap plugins with IPv4/IPv6 switches (e.g. dig, ssh, tcp). Add ssl_cert_ipv4 and ssl_cert_ipv6 following that same established pattern, and document them in the ITL docs. refs Icinga#9979
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @IshanA2007 Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check_ssl_certplugin supports-4/-6to force IPv4 or IPv6, but thessl_certCheckCommand had no way to pass them through.As pointed out in the issue thread, the established pattern in the ITL is that
commands wrapping dual-stack-capable plugins provide their own documented
switches on top of
vars.check_ipv4/check_ipv6(seedig,ssh,tcp).This follows the
digCheckCommand exactly:ssl_cert_ipv4/ssl_cert_ipv6map to the plugin's-4/-6flags.vars.check_ipv4/vars.check_ipv6, so theipv4-or-ipv6template that
ssl_certalready imports picks the matching address familyinstead of handing the plugin an address of the other family.
doc/10-icinga-template-library.md.This supersedes #9978, which used an
ssl_-prefixed variable name, added nodocumentation, and did not set
vars.check_ipv[46].Verified with
icinga2 daemon -Cand by running the daemon against a stubplugin; the rendered command lines are:
fixes #9979