Add a better way to set the base_display function#23
Merged
flying-sheep merged 2 commits intoIRkernel:masterfrom May 10, 2016
jankatins:base_display
Merged
Add a better way to set the base_display function#23flying-sheep merged 2 commits intoIRkernel:masterfrom jankatins:base_display
flying-sheep merged 2 commits intoIRkernel:masterfrom
jankatins:base_display
Conversation
The current way overwrites the function in IRkernel, but R CMD check complains about this. So add a way to use the options system to overwrite the function.
Should be a bit faster but fails more horrible if a user submits a wrong functions there...
Member
|
good idea, but why |
Member
|
I think it's reasonable enough to add _func to the name to make it more obvious what it is. |
Member
|
(The Travis failure is just because master didn't have .travis.yml when it tested this PR, so it tried to run it with the default settings for a ruby project) |
Contributor
Author
|
closed/reopen to rerun travis |
Member
|
Oh, neat trick, I didn't know that that worked. |
Member
|
great stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses the problem in IRkernel/IRkernel#257 (comment)