Skip to content

added Slovak localization (strings, formatter, tests)#124

Merged
MehdiK merged 4 commits into
Humanizr:masterfrom
igorkulman:master
Apr 4, 2014
Merged

added Slovak localization (strings, formatter, tests)#124
MehdiK merged 4 commits into
Humanizr:masterfrom
igorkulman:master

Conversation

@igorkulman

@igorkulman igorkulman commented Apr 3, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@MehdiK

MehdiK commented Apr 3, 2014

Copy link
Copy Markdown
Collaborator

Thanks for this. As mentioned in the issue you've raised we will have to fix DateTimeHumanize tests for all locales by extracting the Verify method out of the base DateTimeHumanize tests and apply it to all the DateTime tests. So we need a PR for this that has to go in before this PR.

MehdiK
MehdiK reviewed Apr 3, 2014
View reviewed changes
Comment thread src/Humanizer.Tests/Localisation/DateHumanizeTests.sk-SK.cs Outdated

@MehdiK MehdiK Apr 3, 2014

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to do one line tests by inlining the calculation and assertions. Please online the humanize in all tests.

@MehdiK

MehdiK commented Apr 3, 2014

Copy link
Copy Markdown
Collaborator

I need to fix up a few things on DateTime tests; so if you could fix up the review comments, extract the Verify method, clean up the DateTime tests, apply Verify on your tests and push it up.

@igorkulman

igorkulman commented Apr 4, 2014

Copy link
Copy Markdown
Contributor Author

I have made the changes

MehdiK added a commit that referenced this pull request Apr 4, 2014
@MehdiK
Merge pull request #124 from igorkulman/master
bd16448 
added Slovak localization (strings, formatter, tests)
@MehdiK MehdiK merged commit bd16448 into Humanizr:master Apr 4, 2014
@MehdiK

MehdiK commented Apr 4, 2014

Copy link
Copy Markdown
Collaborator

Thanks for this.

The tests still fail randomly. So I will have to apply the fix soon.

@MehdiK

MehdiK commented Apr 6, 2014

Copy link
Copy Markdown
Collaborator

The tests were fixed on #131.

This is now released as v1.17.1. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igorkulman @MehdiK