Did a quick compare, these are some things I noticed:

Your HtmlTag is not immutable. Mine started out as a mutable, but after running into some subtle bugs that could have been avoided with immutability, I converted everything a few years ago and haven't looked back.
Take a look at my "HtmlTags" class (note the trailing 's'). It contains shorthands for every HTML element out there. It reduced my use of magic strings (and thus opportunity for typo's) drastically. You seem to have created subclasses for some of the most common ones, but I couldn't a full equivalent in your codebase.
No support for parsing HTML strings / IHtmlContent? I often want to reuse things from an editor template, builtin HTML helper, ... and tweak a few things. So I included HtmlAgilityPack, and that now lets me write code like this:

  Html.LabelFor(m => m.SomeProperty).ToHtmlTag().Class("funky")

If the input implements IHtmlContent, you don't always have to parse HTML, as can be seen here:
https://github.com/amoerie/HtmlBuilders/blob/master/HtmlBuilders/HtmlTag.cs#L663

I probably missed a lot of things, but these stood out the most. I like how you integrate nicely with .NET core, and how you built a whole conventions system to prevent repetitive tasks. Usually, I just create mini HTML helpers for these, or display/editor templates where it makes sense. To be honest, I'm still not sold on tag helpers..

Bundle efforts? #102

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions