fix: truncate strings on UTF-8 boundaries in StrEllipsis - #2514
Merged
ansgarbecker merged 1 commit intoJun 11, 2026
Conversation
StrEllipsis truncated by byte count (SetLength/Copy), which can split a multi-byte UTF-8 character and produce invalid UTF-8. On the Cocoa widgetset such a string becomes a nil NSString, which crashes -[NSMenuItem initWithTitle:] when the result is used as a menu caption (e.g. the data grid quick-filter items built from long non-ASCII values). Use UTF8Length/UTF8Copy (LazUTF8, already used here) to cut on codepoint boundaries.
ansgarbecker
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2510
StrEllipsis truncated strings by byte count, which can split a multi-byte UTF-8 character and produce invalid UTF-8. On the Cocoa widgetset that becomes a nil NSString and crashes -[NSMenuItem initWithTitle:] when the result is used as a menu caption (e.g. the data grid quick-filter items built from long non-ASCII cell values).
Switch truncation to UTF8Length/UTF8Copy (LazUTF8, already used by the unit) so it cuts on codepoint boundaries.