Prevent logo from shrinking on small screens#9
Merged
fazlerocks merged 2 commits intoHashnode:developmentfrom May 18, 2021
sherbakovdev:hotfix-prevent-logo-from-shrinking-on-small-screens
Merged
Prevent logo from shrinking on small screens#9fazlerocks merged 2 commits intoHashnode:developmentfrom sherbakovdev:hotfix-prevent-logo-from-shrinking-on-small-screens
fazlerocks merged 2 commits intoHashnode:developmentfrom
sherbakovdev:hotfix-prevent-logo-from-shrinking-on-small-screens
Conversation
Contributor
sherbakovdev
commented
Feb 2, 2021
Contributor
|
@sherbakovdev It would be better if you use % instead of px. |
Contributor
Author
|
Sorry @Megha-Pathak, but I'm a bit confused about why do you want to have % there. Also, what do you mean by "not completely" fixed? Currently, the logotype is scaling back and forth and not only shrinking in width. Please, decline this PR if you have a different solution in mind, as it is probably faster to fix adding a few lines of code than to spend time on this discussion 😄 Thanks ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.