fix(loaders): keep yahoo 1m as minute bars, not monthly#761
Merged
Conversation
_to_yahoo_interval uppercased intervals before the map lookup, so project interval 1m collided with monthly 1M and was sent to Yahoo as 1mo. Signed-off-by: santhreal <64453045+santhreal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_to_yahoo_interval("1m")uppercased the token to1M, which the Yahoo map treats as monthly (1mo). Minute backtests silently fetched monthly bars.Repro:
_to_yahoo_interval("1m")returned1moon main. Longbridge already maps1mand1Mseparately.Keep case for known minute tokens before the uppercase monthly map, and cover
1m/1M/15m/30min the interval tests.