Skip to content

Fix: Null checks, more fetch error handling - #1684

Merged
arturcic merged 2 commits into
GitTools:mainfrom
IdsTeepe:fix/null-checks
Jul 7, 2025
Merged

Fix: Null checks, more fetch error handling#1684
arturcic merged 2 commits into
GitTools:mainfrom
IdsTeepe:fix/null-checks

Conversation

@IdsTeepe

@IdsTeepe IdsTeepe commented Jul 5, 2025

Copy link
Copy Markdown

Introduces better error handling when fetching nuget sources, logs a bit more information as well for if things go awry

@IdsTeepe IdsTeepe mentioned this pull request Jul 5, 2025
Closed
2 tasks
@IdsTeepe

IdsTeepe commented Jul 6, 2025

Copy link
Copy Markdown
Author

Oh hey, the pipeline fails. That is a great example of the fetch error handling:

Querying tool versions for GitVersion.Tool@6.3.x 
Command: dotnet nuget list source --format short
Warning: Client network socket disconnected before secure TLS connection was established
Warning: Failed to fetch data from NuGet source https://api.nuget.org/v3/index.json.
Error: Unable to find GitVersion.Tool version 'null'.

@arturcic
arturcic enabled auto-merge July 7, 2025 16:55
@arturcic
arturcic merged commit 7aa3ada into GitTools:main Jul 7, 2025
@mergify

mergify Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Thank you @IdsTeepe for your contribution!

@arturcic arturcic added this to the v4.x milestone Jul 7, 2025
@arturcic arturcic added the bug Something isn't working label Jul 7, 2025
@arturcic arturcic modified the milestones: v4.x, v4.0.1 Jul 7, 2025
@gittools-bot

gittools-bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

🎉 This issue has been resolved in version v4.0.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

arturcic added a commit to arturcic/gittools-actions that referenced this pull request Aug 4, 2025
@arturcic
Revert "Merge pull request GitTools#1684 from IdsTeepe/fix/null-checks"
a746014 
This reverts commit 7aa3ada, reversing
changes made to 2d62f87.
@arturcic arturcic mentioned this pull request Aug 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturcic arturcic arturcic approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

v4.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@IdsTeepe @gittools-bot @arturcic