Implement sorting for remaining favourites + playlists#328
Merged
tehkillerbee merged 2 commits intoEbbLabs:masterfrom Jul 7, 2025
Merged
Implement sorting for remaining favourites + playlists#328tehkillerbee merged 2 commits intoEbbLabs:masterfrom
tehkillerbee merged 2 commits intoEbbLabs:masterfrom
Conversation
Collaborator
|
Hello and sorry for the slow review. This is indeed a very useful feature that you have added and something I have been wanting to add for a long time. I'll try to write some simple tests to verify your additions (and fix the other tests that are now broken again. Thanks for the headsup!) |
Collaborator
|
Not quite done with the tests, but will merge this one now as everything seems to be working as expected 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds enums for the individual sorting types available per favourite and also implements them for all favourites and playlists.
I was not able to directly test the python code, but I did test the HTTP requests manually. Make Test run had some errors, but seems very unrelated to the changes here so I think we are good.
Failed Tests
Closes #212