Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Created a rule for Ooredoo.qa#412

Closed
AddaxSoft wants to merge 6 commits intoEFForg:masterfrom
AddaxSoft:master
Closed

Created a rule for Ooredoo.qa#412
AddaxSoft wants to merge 6 commits intoEFForg:masterfrom
AddaxSoft:master

Conversation

@AddaxSoft
Copy link
Copy Markdown

Tested and it is working.

@semenko
Copy link
Copy Markdown
Contributor

semenko commented Aug 20, 2014

Cool -- thanks for this! It looks like some Reddit rule changes also made it into your commit. If you remove them (we made them recently, too) I'd be happy to merge the Ooredoo changes. Thanks!

@semenko
Copy link
Copy Markdown
Contributor

semenko commented Aug 28, 2014

Hey @AddaxSoft -- I'm going to close this PR for now, since we have the reddit rules already added in master. Happy to add the Vodaphone rules in a separate pull request (or reopen here without the reddit rule).

Thanks!

@semenko semenko closed this Aug 28, 2014
@AddaxSoft
Copy link
Copy Markdown
Author

@semenko sorry about this very late reply, but how do reopen the pull request without reddit rule?

@semenko
Copy link
Copy Markdown
Contributor

semenko commented Oct 16, 2014

You'll need to either revert those changes from your branch, or you can also create a new branch, copy over your changes, and create a new pull request.

You might try creating an entirely new pull request with just the rules you're interested in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants