Conversation
jaceksocha
previously approved these changes
May 7, 2018
kwarunek
previously approved these changes
May 7, 2018
README.rst
Outdated
| ============ | ||
|
|
||
| The `AsyncOpenStackClient` is a rest wrapper for the OpenStack API. It provides very raw functionality; however, it has a nice abstraction for authentication. For method specification, see the official OpenStack documentation: https://docs.openstack.org/queens/api/. | ||
| The `AsyncOpenStackClient` is a asynchronous rest wrapper for the OpenStack API. It provides a nice abstraction for authentication and wraps some (not all of them) methods for the OpenStack Compute API. For method specification, see the official OpenStack documentation: https://docs.openstack.org/queens/api/. |
Contributor
There was a problem hiding this comment.
I would drop "and wraps some ... Compute API" part, because it has been mentioned already (methods listing below)
src/asyncopenstackclient/proxy.py
Outdated
| def __call__(self, *args, **kwargs): | ||
| return self.__await__(*args, **kwargs) | ||
|
|
||
| def __await__(self, *args, **kwargs): |
Contributor
There was a problem hiding this comment.
IMHO __await__ is a bit confusing, despite the code you can't do await obj
Contributor
Author
There was a problem hiding this comment.
shall we just move it to __call__?
kwarunek
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides more natural way to interact with OS api. From now on, there is no need to provide
bodyandparamsas kwargs, one need to pass its parameters viaargsandkwargs. To achieve that,ResourceProxyandMethodProxyhas been implemented.