Fixed bug: Smart detection when dialog opened#1027
Merged
veler merged 1 commit intoJan 24, 2024
Conversation
btiteux
approved these changes
Jan 24, 2024
veler
deleted the
dev/2.0-fix-bug-smart-detection-navigating-when-dialog-opened
branch
January 24, 2024 06:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
DevToys will switch to the Markdown Preview tool because of Smart Detection. The dialog will still be opened but will be empty (no content inside). User is trapped. No way to close the dialog.
What is the new behavior?
We do not run Smart Detection while a dialog is opened.
Other information
Quality check
Before creating this PR: