Skip to content

Fixed bug: Smart detection when dialog opened#1027

Merged
veler merged 1 commit into
dev/2.0from
dev/2.0-fix-bug-smart-detection-navigating-when-dialog-opened
Jan 24, 2024
Merged

Fixed bug: Smart detection when dialog opened#1027
veler merged 1 commit into
dev/2.0from
dev/2.0-fix-bug-smart-detection-navigating-when-dialog-opened

Conversation

@veler

@veler veler commented Jan 15, 2024

Copy link
Copy Markdown
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

  1. Go to Extension Manager
  2. Click "Install". A dialog asking to click "I understand" opens.
  3. Go in VS Code or web browser: Copy a Markdown code
  4. Go back to DevToys.

DevToys will switch to the Markdown Preview tool because of Smart Detection. The dialog will still be opened but will be empty (no content inside). User is trapped. No way to close the dialog.

What is the new behavior?

We do not run Smart Detection while a dialog is opened.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler
veler requested a review from btiteux January 15, 2024 14:11
@veler veler added the devtoys-v2.0 DevToys v2.0 label Jan 16, 2024
@veler
veler merged commit 8672ee1 into dev/2.0 Jan 24, 2024
@veler
veler deleted the dev/2.0-fix-bug-smart-detection-navigating-when-dialog-opened branch January 24, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtoys-v2.0 DevToys v2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants