Skip to content

Conversation

@johanohly
Copy link
Contributor

Description

I have finished the danish language support.

Type of change

  • New feature (added a non-breaking change which adds functionality)

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • My changes generate no new warnings

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for contributing 👍

@DenverCoder1 DenverCoder1 changed the title Improved danish language coverage feat: Updated Danish translations Jan 30, 2023
@johanohly johanohly closed this Jan 30, 2023
@DenverCoder1 DenverCoder1 merged commit 0365147 into DenverCoder1:main Jan 30, 2023
@johanohly johanohly deleted the patch-1 branch January 30, 2023 09:05
@DenverCoder1
Copy link
Owner

@JohnnyJTH It appears to me like this was closed before the merge. Are there any issues that need to be resolved?

Screenshot_20230130-020810

@johanohly
Copy link
Contributor Author

Oopsie, was I too quick? I am not that experienced with github :)

@johanohly
Copy link
Contributor Author

It still worked right?

@DenverCoder1
Copy link
Owner

Yeah, it looks like it still worked.

I was just wondering if you had changed your mind about it or something. Just so you know, PRs can always be updated by pushing to the branch and can't easily be merged after the branch is deleted. In this case, it seems like it was merged right before the branch was deleted.

@johanohly
Copy link
Contributor Author

Perfect, yeah no I didn't want to make any changes, just saw the accepted message and closed it. Didn't notice it wasn't merged yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants