[dev] C1 - centralize project config I/O and add testing#3190
Merged
deruyter92 merged 7 commits intofeat/structured_configsfrom Feb 4, 2026
Merged
[dev] C1 - centralize project config I/O and add testing#3190deruyter92 merged 7 commits intofeat/structured_configsfrom
deruyter92 merged 7 commits intofeat/structured_configsfrom
Conversation
C-Achard
reviewed
Jan 30, 2026
C-Achard
reviewed
Jan 30, 2026
deeplabcut/modelzoo/generalized_data_converter/datasets/materialize.py
Outdated
Show resolved
Hide resolved
C-Achard
reviewed
Jan 30, 2026
C-Achard
reviewed
Jan 30, 2026
20 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/pose_estimation_pytorch/modelzoo/test_generalized_data_converter_config.py
Outdated
Show resolved
Hide resolved
…onverter_config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
0009cdf to
29f3499
Compare
C-Achard
reviewed
Feb 3, 2026
C-Achard
reviewed
Feb 3, 2026
C-Achard
reviewed
Feb 3, 2026
Collaborator
C-Achard
left a comment
There was a problem hiding this comment.
Very good, I hope my above comments make sense; if they do need further action I'll wait a bit before approving
tests/pose_estimation_pytorch/modelzoo/test_generalized_data_converter_config.py
Show resolved
Hide resolved
- reading breaks for corrupted yaml - added tests for prefered behavior that is currently not implemented (yaml safeloading and validating config keys)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the WIP for migrating from dictionary configs to typed & validated configurations (see #3193 for an overview).
Goal of this PR:
Centralize the logic for reading, writing and adjusting configurations. And improve test coverage of the current behavior (before changing to a different configuration setup).
Motivation:
Currently reading and writing yaml files, and the logic for adjusting configuration files is spread across different places in the repository.
Changes
core.configauxiliaryfunctionsto keep existing references in place for backwards compatibilitygeneralized_data_converterThis PR only pertains to project configs and core yaml reading / writing. The pose configs in pytorch pose estimation are kept unchanged.