Fix: Type Confusion vulnerability in cJSONUtils_ApplyPatches#1006
Merged
Alanscut merged 1 commit intoDaveGamble:masterfrom Apr 9, 2026
Merged
Fix: Type Confusion vulnerability in cJSONUtils_ApplyPatches#1006Alanscut merged 1 commit intoDaveGamble:masterfrom
Alanscut merged 1 commit intoDaveGamble:masterfrom
Conversation
Alanscut
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a Type Confusion vulnerability found in
cJSON_Utils.c.Root Cause
When processing certain JSON patches (e.g.,
[{"op":"move","from":0,"path":"/obj/b"}]), the code checks if thefromnode exists (from == NULL), but fails to validate if it is actually a string before operating on it. This causes the program to treat non-string objects (like integers or objects) as strings, leading to Type Confusion and potential Segmentation Faults (SIGSEGV) or Out-Of-Bounds (OOB) reads when searching/applying patches.The Fix
Added a stricter validation check using
cJSON_IsString(from)instead of just checking forNULLto ensure the structure is safe before moving forward.Impact
Prevents denial of service (DoS) and memory access violations when untrusted, malformed JSON patches are supplied to the utility API.