v0.5.3 Release Candidate#163
Merged
ultranoobian merged 26 commits intoDUWS-R-Team:masterfrom Dec 9, 2017
Merged
Conversation
When player rating goes below -2000, the player is deemed 'Traitor' and is treated as an enemy by ALL factions and KOS. This EH checks for negative rating (currently below zero) and resets back to zero. If the future rating value is negative, the rating change is set to zero else continues normally. Referencing: DUWS-R-Team#151
…ler' into development
findEmptyPosition is less complicated and sensitive. DUWS-R-Team#156
Added missing bracket
Missing brackets caused rating expression to be interpreted unexpectedly
Refactored vehicle spawning code into seperate file to reduce duplication, enhance readability, and reduce error. Order of values to be passed to the new 'spawnVehicle.sqf' are [CP Cost, Vehicle Type]
# Conflicts: # source/dialog/request_vehicle.sqf
Previously would always decrease CP pool by four CP due to Copy-paste error. Now it actually does reduce CP pool by passed parameter.
Reduced minimum spawning distance for vehicles from 50 to 15 metres Added code guard in case it didn't find a valid spot for the vehicle, instead it will abort and give the player a helpful message tell them why the vehicle hasn't spawned
Moved mission parameter outside of the MP-Only code block, and defaulted to Stamina System to be OFF until BI introduces an option to have Mission parameters for SP missions
Changed "" into valid equiv. enum "NONE"
Contributor
Author
|
Reviewed 1 of 5 files at r4, 3 of 6 files at r5, 1 of 2 files at r6, 3 of 3 files at r7, 1 of 1 files at r8. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is