Draft
Conversation
akiraveliara
requested changes
May 29, 2025
Member
akiraveliara
left a comment
There was a problem hiding this comment.
in addition to the other comments, please ensure xmldocs in DiscordSoundboardSound are complete sentences and terminated properly - in particular, the skipCache documentation does not at all clarify what the parameter does without background knowledge.
Comment on lines
+7249
to
+7261
| internal sealed record RestModifySoundboardSoundPayload | ||
| { | ||
| [JsonProperty("name")] | ||
| public required string Name { get; init; } | ||
|
|
||
| [JsonProperty("volume")] | ||
| public Optional<double>? Volume { get; init; } | ||
|
|
||
| [JsonProperty("emoji_id")] | ||
| public Optional<ulong>? EmojiId { get; init; } | ||
|
|
||
| [JsonProperty("emoji_name")] | ||
| public Optional<string>? EmojiName { get; init; } |
Member
There was a problem hiding this comment.
should go into its own file
| await this.rest.ExecuteRequestAsync(request); | ||
| } | ||
|
|
||
| internal async ValueTask<DiscordSoundboardSound> GetGuildSoundboardSoundAsync(ulong guildId, ulong soundId) |
Member
There was a problem hiding this comment.
please make these methods public
Member
Author
|
Aki, thanks for the review but the pr is highly wip and therefore a draft |
Member
Author
|
Maybe i should have put that in the description |
39036f5 to
91263db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.