Upgrade project from Java 8 to Java 17 - #2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the build target from Java 8 to Java 17.
pom.xml:maven.compiler.source/maven.compiler.target=1.8properties with a singlemaven.compiler.release=17(the modern, preferred approach).<source>8</source>to17.maven-compiler-pluginto3.13.0. This was required: the parent POM (oss-parent:9) inheritsmaven-compiler-plugin:3.1, which ignoresmaven.compiler.releaseand fell back to source/target5, failing under JDK 17 withSource option 5 is no longer supported.Dockerfile:maven:3.6.3-jdk-8→maven:3.9.9-eclipse-temurin-17(CI builds/runs tests from this image).No other plugins needed changes —
maven-surefire-plugin/maven-failsafe-plugin(2.19.1) run fine under JDK 17, andcobertura-maven-pluginhas no lifecycle-bound execution so it never runs duringverify.Verification
JAVA_HOME=<jdk17> mvn clean package→ BUILD SUCCESS: 2069 main + 63 test sources compile withjavac [release 17]; jar, sources jar, and javadoc jar all build.mvn clean verifyfails locally only on the integration tests, which requirePLAID_CLIENT_ID/PLAID_SECRET(supplied via env in CI) — unrelated to the JDK upgrade.Link to Devin session: https://app.devin.ai/sessions/0f802bfb417f498db0468d240cd58f6c
Requested by: @DS2853