feat(diff): Added ability to ignore rows using regular expression#35
Open
NTlegend wants to merge 1 commit intoDBDiff:masterfrom
Open
feat(diff): Added ability to ignore rows using regular expression#35NTlegend wants to merge 1 commit intoDBDiff:masterfrom
NTlegend wants to merge 1 commit intoDBDiff:masterfrom
Conversation
jasdeepkhalsa
requested changes
Feb 16, 2017
Member
jasdeepkhalsa
left a comment
There was a problem hiding this comment.
Hi here NTlegend!
Thanks for the great suggestion and PR - I think people will find this really useful!
Two comments:
- I would prefer that instead of creating a new API for this, that it's rolled into the existing ignore tables and fields feature e.g.
tablesToIgnore:
- table*
fieldsToIgnore:
table1:
- field_wp_*
table_wp*:
- [a-zA-Z]\d*\.\d*.- This feature should be tested thoroughly to ensure it does not break the existing functionality or the ordinary operation of DBDiff. Test cases would be welcome (even though we currently don't have any)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature helpful for WordPress sites where we have many data rows in tables like wp_options.