Merged
Conversation
The src/ overlay (git checkout $REF -- src/) was partially overwriting master files with incompatible old code — e.g. DefaultParams.php from v2.0.1 (no $description) would replace the fixed master version while DiffCommand.php from master (which sets $params->description) stayed, causing the PHP 8.2 deprecation notice in every build. The two codebases are architecturally incompatible across the old/new boundary so the overlay concept does not work. Releases always build from master HEAD (whatever branch the workflow is dispatched from). The version number is now stamped via src/Version.php which is written by the workflow before Box compiles, so dbdiff --version reports the correct version. The unused 'ref' workflow input is also removed.
- composer run build:phar now builds dist/dbdiff.phar locally (version will show as 'dev' since src/Version.php defaults to that) - box.json check-requirements: true so PHP version is checked at PHAR startup — users on PHP < 8.1 get a clean error instead of a crash
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(release): remove broken src overlay; stamp version via constant
The src/ overlay (git checkout $REF -- src/) was partially overwriting
master files with incompatible old code — e.g. DefaultParams.php from
v2.0.1 (no $description) would replace the fixed master version while
DiffCommand.php from master (which sets $params->description) stayed,
causing the PHP 8.2 deprecation notice in every build.
The two codebases are architecturally incompatible across the old/new
boundary so the overlay concept does not work. Releases always build
from master HEAD (whatever branch the workflow is dispatched from).
The version number is now stamped via src/Version.php which is written
by the workflow before Box compiles, so dbdiff --version reports the
correct version. The unused 'ref' workflow input is also removed.
chore: add build:phar composer script; enable PHAR requirement check
will show as 'dev' since src/Version.php defaults to that)
startup — users on PHP < 8.1 get a clean error instead of a crash