fix(release): separate source checkout from tooling checkout#152
Merged
jasdeepkhalsa merged 1 commit intomasterfrom Mar 10, 2026
Merged
fix(release): separate source checkout from tooling checkout#152jasdeepkhalsa merged 1 commit intomasterfrom
jasdeepkhalsa merged 1 commit intomasterfrom
Conversation
The PHAR build always needs master's box.json and humbug/box in composer.json. Checking out an old tag (e.g. v2.0.1) breaks the build because Box wasn't in composer.json at that point. Fix: PHAR build job now checks out master for tooling, then overlays src/ from the release ref (tag/SHA) so the PHAR contains the correct PHP source. All other jobs (binary, publish, docker) also revert to master checkout since they only need npm package metadata and Dockerfiles.
8ee2d5f to
bd67e39
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHAR build always needs master's box.json and humbug/box in composer.json. Checking out an old tag (e.g. v2.0.1) breaks the build because Box wasn't in composer.json at that point.
Fix: PHAR build job now checks out master for tooling, then overlays src/ from the release ref (tag/SHA) so the PHAR contains the correct PHP source. All other jobs (binary, publish, docker) also revert to master checkout since they only need npm package metadata and Dockerfiles.