fix: win32-x64 build, PHP 8.2 deprecation, and release workflow tag checkout#151
Merged
jasdeepkhalsa merged 3 commits intomasterfrom Mar 8, 2026
Merged
fix: win32-x64 build, PHP 8.2 deprecation, and release workflow tag checkout#151jasdeepkhalsa merged 3 commits intomasterfrom
jasdeepkhalsa merged 3 commits intomasterfrom
Conversation
…build
Upstream SPC bug: nmake_micro_wrapper.bat omits zlibstatic.lib from
LIBS_MICRO even when zlib is a dependency. SPC reads SPC_EXTRA_LIBS
and appends it to LIBS_MICRO/LIBS_CLI, so setting it here works around
the issue until the upstream fix lands.
The root fix in SPC is a two-line change in WindowsBuilder::buildMicro()
and buildCli() to check getLib('zlib') and prepend zlibstatic.lib.
…ion) PHP 8.2 deprecated dynamic property creation. DiffCommand was setting $params->description but DefaultParams had no declared $description property, triggering a deprecation notice on every run.
workflow_dispatch without a ref defaults to the workflow's default
branch (master HEAD at dispatch time). This caused v2.0.0 npm packages
to be built from code that was ahead of the v2.0.0 git tag.
Now each checkout uses:
ref: inputs.ref || 'v{version}'
A ref override input is also exposed so re-runs or backfills can target
a specific branch/SHA without changing the version number.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: win32-x64 build, PHP 8.2 deprecation, and release workflow tag checkout
Three fixes, all discovered during the v2.0.0 release process.
1. Release workflow builds from master HEAD, not the version tag (
fc0da9b)workflow_dispatchwithout arefalways checks out the default branch at dispatch time,regardless of the version number typed in. This caused the v2.0.0 npm packages to be built
and published from master HEAD (which included Supabase/PostgreSQL/multi-format features
not in the v2.0.0 tag).
Fix: All four
actions/checkout@v4steps now resolve the ref asinputs.refif provided, otherwisev{version}(e.g.v2.0.1).A
refoverride input is also exposed so re-runs or backfills can target a specificbranch/SHA. The intended process going forward:
git tag v2.0.1 && git push origin v2.0.1)version: 2.0.1— it checks outv2.0.1automatically2. win32-x64 native build fails with 14 unresolved zlib symbols (
33822ac)Upstream SPC bug:
nmake_micro_wrapper.batomitszlibstatic.libfromLIBS_MICROeven when
zlibis in the dependency list, despitezlibstatic.libbeing present inbuildroot\lib\after a successful zlib build. The OpenSSL builder has a manualworkaround for the same issue in its own linker step, but it does not carry through to
the PHP link step.
Workaround: Set
SPC_EXTRA_LIBS=zlibstatic.libbefore callingspc.exe build. SPCalready reads this env var and appends it to both
LIBS_MICROandLIBS_CLI. An upstreamissue/PR has been prepared for the root fix in
WindowsBuilder::buildMicro()/buildCli().3. PHP 8.2 deprecation notice on every
dbdiffinvocation (89fa4cc)DiffCommandassigns$params->descriptionbutDefaultParamshad no declared$descriptionproperty. PHP 8.2 deprecated dynamic property creation, producing aDeprecated:notice on stderr on every run. Not a functional breakage (works fineuntil PHP 9.0) but noisy.
Fix: Added
public $description = '';toDefaultParams.