Address PR review feedback: security, reproducibility, and code hygiene#138
Merged
jasdeepkhalsa merged 4 commits intopr/108from Feb 9, 2026
Merged
Address PR review feedback: security, reproducibility, and code hygiene#138jasdeepkhalsa merged 4 commits intopr/108from
jasdeepkhalsa merged 4 commits intopr/108from
Conversation
Merged
…nt requires, fix git config, update composer Co-authored-by: jasdeepkhalsa <41632+jasdeepkhalsa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Prepare for version 2.0.0 release
Address PR review feedback: security, reproducibility, and code hygiene
Feb 9, 2026
This reverts commit 432d65b.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses 11 actionable review comments from the v2.0.0 preparation PR focusing on security hardening, environment reproducibility, and test infrastructure improvements.
Security & Git Hygiene
.envfile (conflicts with.gitignore, contains default credentials)ext-PDO→ext-pdoincomposer.json(Composer convention)Docker & CI/CD
5.2(removed:latestfor reproducibility)user.nameset twice instead ofuser.email)Test Infrastructure
require 'vendor/autoload.php'from test files (already bootstrapped)exit(1)with$this->fail()in test setUp (proper PHPUnit error handling)DBDIFF_DEBUGenv var to reduce CI noiseShell Scripts
stop.shbanner (replacement character → emoji)localkeyword used outside function instart.sh(bash error in interactive mode)Example of debug output change:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.