Skip to content

Address PR review feedback: security, reproducibility, and code hygiene#138

Merged
jasdeepkhalsa merged 4 commits intopr/108from
copilot/sub-pr-136
Feb 9, 2026
Merged

Address PR review feedback: security, reproducibility, and code hygiene#138
jasdeepkhalsa merged 4 commits intopr/108from
copilot/sub-pr-136

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Addresses 11 actionable review comments from the v2.0.0 preparation PR focusing on security hardening, environment reproducibility, and test infrastructure improvements.

Security & Git Hygiene

  • Removed committed .env file (conflicts with .gitignore, contains default credentials)
  • Fixed ext-PDOext-pdo in composer.json (Composer convention)

Docker & CI/CD

  • Pinned phpMyAdmin to 5.2 (removed :latest for reproducibility)
  • Fixed release workflow git config (user.name set twice instead of user.email)

Test Infrastructure

  • Removed redundant require 'vendor/autoload.php' from test files (already bootstrapped)
  • Replaced exit(1) with $this->fail() in test setUp (proper PHPUnit error handling)
  • Gated debug output behind DBDIFF_DEBUG env var to reduce CI noise

Shell Scripts

  • Fixed encoding issue in stop.sh banner (replacement character → emoji)
  • Removed local keyword used outside function in start.sh (bash error in interactive mode)

Example of debug output change:

// Before: unconditional noise in CI
echo "\nDEBUG: DB_HOST environment variable: " . $host;

// After: opt-in debugging
if (getenv('DBDIFF_DEBUG') === 'true') {
    echo "\nDEBUG: DB_HOST environment variable: " . $host;
}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…nt requires, fix git config, update composer

Co-authored-by: jasdeepkhalsa <41632+jasdeepkhalsa@users.noreply.github.com>
Copilot AI changed the title [WIP] Prepare for version 2.0.0 release Address PR review feedback: security, reproducibility, and code hygiene Feb 9, 2026
Copilot AI requested a review from jasdeepkhalsa February 9, 2026 02:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@jasdeepkhalsa jasdeepkhalsa marked this pull request as ready for review February 9, 2026 02:08
@jasdeepkhalsa jasdeepkhalsa merged commit 2a3582e into pr/108 Feb 9, 2026
1 check passed
@jasdeepkhalsa jasdeepkhalsa deleted the copilot/sub-pr-136 branch February 18, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants