Skip to content

feat: upgrade dependencies to use latest PHP version +Illuminate + phpunit + symfony/yml#108

Open
celorodovalho wants to merge 1 commit intoDBDiff:masterfrom
celorodovalho:master
Open

feat: upgrade dependencies to use latest PHP version +Illuminate + phpunit + symfony/yml#108
celorodovalho wants to merge 1 commit intoDBDiff:masterfrom
celorodovalho:master

Conversation

@celorodovalho
Copy link

update the code to follow changes in the dependencies

…the code to follow changes in the dependencies
@celorodovalho celorodovalho changed the title feat: upgrade dependencies to use latest Illuminate version, phpunit, symfony/yml feat: upgrade dependencies to use latest PHP version +Illuminate + phpunit + symfony/yml Nov 19, 2020
@celorodovalho celorodovalho mentioned this pull request Nov 19, 2020
@jasdeepkhalsa
Copy link
Member

This is excellent stuff @celorodovalho ! Thanks so much for this PR.

Have you tested any particular scenarios in your PR? If you could please list them, then I can help test the rest.
Also does your PR close any of the other listed issues? If so, could you note them in your PR or in your commit message please?

I really need to write out a list of manual testing scenarios as automated database and CLI testing has proven to be an extremely difficult challenge (and is really the only reason I've not merged any other PRs in so far), but at least manual scenarios might help push this project forward.

@celorodovalho
Copy link
Author

@jasdeepkhalsa I ran the phpunit test on test/ folder besides the manual tests for ./dbdiff server1.db1:server1.db2, it's working smoothly.
I couldn't check the open issues, but I can do that.
Maybe if you specify which should I test manually with this PR, I can provide this scenario tests.

@jasdeepkhalsa
Copy link
Member

Thanks @celorodovalho.

For now if you could please test each of the CLI Command-Line API still works as expected by running DBDiff with:

  • Local against a remote MySQL database (should also work local:local, remote:local, local:remote, remote:remote)
  • Schema only diff --type=schema (should output only the schema diff)
  • Data only diff --type=data (should output only the data diff)
  • With a template migration format output: --template=templates/simple-db-migrate.tmpl (should output according to the template format provided)
  • Diff output --include=up command (should only produce UP SQL output)
  • Diff output --include=down command (should only produce DOWN SQL output)
  • Diff against only one specific MySQL table with server1.db1.table1:server2.db2.table3 parameters (should only produce a diff for the specific table provided)
  • Using a config file: --config=config.yaml file (should work the same as specifying the above parameters in the CLI directly, however the CLI parameters always take preference over the config, so you can try to override one of them here too)
  • Config file with a tablesToIgnore: setting (should ignore that table from the diff)
  • Config file with a fieldsToIgnore: table1: setting (should ignore that field from a specific table from the diff)

Sorry it's a lot to test! Let me know if you need any help with it.

@jasdeepkhalsa
Copy link
Member

@celorodovalho Based off your branch I've just added branch https://github.com/DBDiff/DBDiff/tree/pr/108 which adds Docker and docker-compose for spinning up a whole environment for testing DBDiff. Hopefully this should help us test this and future PRs thoroughly.

BTW this PR is already looking good as I've just done some extensive testing with it - so just a little more to do around the CLI commands as above and it should be good for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants