This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Closed
Conversation
Author
|
final week1 homw work submission by zubeda |
Author
|
done |
Shukriy
approved these changes
May 18, 2020
Shukriy
left a comment
There was a problem hiding this comment.
Well done for completing your first HTML/CSS homework. The website has all the essential elements and great use of semantic HTML tags.
Things that went well
- The website has clear title and description
- You have used first-child well and I appreciated the consistency in the colour used.
Things that you can improve on
- the lay out of the website (try to use the example given) and use images in a more useful way
- Your commit messages need to be more descriptive
Overall great work Zubeda and I am looking forward seeing your next homework. You should be proud of yourself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
submission week 1 home work