refactor(services): Should store data internally and return a reference

pilsy · pilsy · commit 040d08d57f48 · 2015-06-19T04:41:23.000+10:00
diff --git a/app/modules/auth/services/UserService.js b/app/modules/auth/services/UserService.js
@@ -1,28 +1,35 @@
-define( [ 'angular', '../module' ], function( ng ) {
+define(['angular', '../module'], function(ng) {
   'use strict';
 
   ng
-  .module( 'auth.services' )
-  .factory( 'UserService', function( UserModel ) {
-    return {
+  .module('auth.services')
+  .factory('UserService', function(UserModel) {
+    var UserService = {
       model: UserModel,
 
-      list: function( findOptions ) {
-        return UserModel.list( findOptions ).$promise;
+      data: null,
+
+      list: function(findOptions) {
+        return UserModel.list(findOptions).$promise.then(function(users) {
+          UserService.data = users;
+          return UserService.data;
+        });
       },
 
-      get: function( findOptions ) {
-        return UserModel.get( findOptions ).$promise;
+      get: function(findOptions) {
+        return UserModel.get(findOptions).$promise;
       },
 
-      create: function( data ) {
-        return UserModel.create( data ).$promise;
+      create: function(data) {
+        return UserModel.create(data).$promise;
       },
 
-      confirm: function( data ) {
-        return UserModel.confirm( data ).$promise;
+      confirm: function(data) {
+        return UserModel.confirm(data).$promise;
       }
     };
+
+    return UserService;
   });
 
 });
diff --git a/app/modules/roles/services/PermissionService.js b/app/modules/roles/services/PermissionService.js
@@ -1,24 +1,31 @@
-define( [ 'angular', '../module' ], function( ng ) {
+define(['angular', '../module'], function(ng) {
   'use strict';
 
   ng
-  .module( 'roles.services' )
-  .factory( 'PermissionService', function( PermissionModel ) {
-    return {
+  .module('roles.services')
+  .factory('PermissionService', function(PermissionModel) {
+    var PermissionService = {
+
       model: PermissionModel,
 
-      list: function( findOptions ) {
-        return PermissionModel.list( findOptions ).$promise;
+      data: null,
+
+      list: function(findOptions) {
+        return PermissionModel.list(findOptions).$promise.then(function(permissions) {
+          PermissionService.data = permissions;
+          return PermissionService.data;
+        });
       },
 
-      get: function( findOptions ) {
-        return PermissionModel.get( findOptions ).$promise;
+      get: function(findOptions) {
+        return PermissionModel.get(findOptions).$promise;
       },
 
-      create: function( data ) {
-        return PermissionModel.create( data ).$promise;
+      create: function(data) {
+        return PermissionModel.create(data).$promise;
       }
     };
-  });
 
+    return PermissionService;
+  });
 });
diff --git a/app/modules/roles/services/RoleService.js b/app/modules/roles/services/RoleService.js
@@ -1,24 +1,31 @@
-define( [ 'angular', '../module' ], function( ng ) {
+define(['angular', '../module'], function(ng) {
   'use strict';
 
   ng
-  .module( 'roles.services' )
-  .factory( 'RoleService', function( RoleModel ) {
-    return {
+  .module('roles.services')
+  .factory('RoleService', function(RoleModel) {
+    var RoleService = {
+
       model: RoleModel,
 
-      list: function( findOptions ) {
-        return RoleModel.list( findOptions ).$promise;
+      data: null,
+
+      list: function(findOptions) {
+        return RoleModel.list(findOptions).$promise.then(function(roles) {
+          RoleService.data = roles;
+          return RoleService.data;
+        });
       },
 
-      get: function( findOptions ) {
-        return RoleModel.get( findOptions ).$promise;
+      get: function(findOptions) {
+        return RoleModel.get(findOptions).$promise;
       },
 
-      create: function( data ) {
-        return RoleModel.create( data ).$promise;
+      create: function(data) {
+        return RoleModel.create(data).$promise;
       }
     };
-  });
 
+    return RoleService;
+  });
 });
