'Too many words in string' should be a warning, not an error#5
Merged
ChatScript merged 1 commit intoChatScript:masterfrom Jan 31, 2019
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By being a warning and saying "will never match", it appears as if ChatScript will fail to match the given pattern, but this is not true. In our instance, we know exactly what is being sent in, and it should match exactly as given.
Therefore, this should be a warning for bot quality guidance and not an error that completely blocks the build.
(recreation of https://github.com/bwilcox-1234/ChatScript/pull/225)