Fixed D->counter issue in MacOS and built Mac binary for 8.8#11
Closed
MaffooBristol wants to merge 1 commit intoChatScript:masterfrom
Closed
Fixed D->counter issue in MacOS and built Mac binary for 8.8#11MaffooBristol wants to merge 1 commit intoChatScript:masterfrom
MaffooBristol wants to merge 1 commit intoChatScript:masterfrom
Conversation
Contributor
Author
|
Just tested on Ubuntu and it appears to |
Collaborator
|
discardcounter removes the definition of counter (saving space in the
dictionary). I have pushed to git fixes that remove the now dead code so
it will compile. Otherwise you can take your source and just comment out
the lines that have errors since the functions they come in are irrelevant.
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
…On Thu, Nov 29, 2018 at 6:57 AM Matt Fletcher ***@***.***> wrote:
Hi @chatscriptnlp <https://github.com/chatscriptnlp>
A regression was brought in, in version 8.7, when building for MacOS. It
seems it errors in testing.cpp but I see another reference in the
functionExecute.cpp, so I don't know why it didn't fail in there? 🤔
testing.cpp:5435:28: error: no member named 'counter' in 'WORDENTRY'
if (count >= 1) D->counter += 1; // how many files have it significantly
~ ^
testing.cpp:5472:24: error: no member named 'counter' in 'WORDENTRY'
if (weak || D->counter >= 10 || *word == '~' || IsDigitWord(word)) // not enough discrimination
~ ^
testing.cpp:5475:51: error: no member named 'counter' in 'WORDENTRY'
fprintf(outbad, "%d %6.6d %s\r\n", D->counter,count, word);
~ ^
testing.cpp:5480:52: error: no member named 'counter' in 'WORDENTRY'
fprintf(outgood, "%d %6.6d %s\r\n", D->counter, count, word);
~ ^
testing.cpp:5481:20: error: no member named 'counter' in 'WORDENTRY'
if (D->counter == 1)
I'll be truthful and say I don't know what define DISCARDCOUNTER 1 means,
but it seems to build fine on Mac with it commented out. Would appreciate
any feedback on what it does and whether removing it is okay?
Cheers!
Matt
------------------------------
You can view, comment on, or merge this pull request online at:
#11
Commit Summary
- Fixed D->count issue in MacOS and built Mac binary for 8.8
File Changes
- *M* BINARIES/MacChatScript
<https://github.com/ChatScript/ChatScript/pull/11/files#diff-0> (0)
- *M* SRC/common.h
<https://github.com/ChatScript/ChatScript/pull/11/files#diff-1> (2)
Patch Links:
- https://github.com/ChatScript/ChatScript/pull/11.patch
- https://github.com/ChatScript/ChatScript/pull/11.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhmSyl3tr_OlGNBDe3lKIKi0InFKVF3wks5uz_XNgaJpZM4Y52Mn>
.
--
CEO of Brillig Understanding Inc. (Natural Language applications)
brilligunderstanding.com
805-547-1109
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
|
Merged
Contributor
Author
|
Thanks Bruce. Your latest code builds fine on Mac so I've included the Binary there: Will close this one now. Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chatscriptnlp
A regression was brought in, in version 8.7, when building for MacOS. It seems it errors in
testing.cppbut I see another reference in thefunctionExecute.cpp, so I don't know why it didn't fail in there? 🤔I'll be truthful and say I don't know what
define DISCARDCOUNTER 1means, but it seems to build fine on Mac with it commented out. Would appreciate any feedback on what it does and whether removing it is okay?Cheers!
Matt