fix(docs): correct Fp12 multiplication formula notation#409
Open
Lil-Duckling-22 wants to merge 1 commit intoBitVM:mainfrom
Open
fix(docs): correct Fp12 multiplication formula notation#409Lil-Duckling-22 wants to merge 1 commit intoBitVM:mainfrom
Lil-Duckling-22 wants to merge 1 commit intoBitVM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The documentation contained incorrect mathematical notation in the Fp12 multiplication verification formulas. The formulas incorrectly included
.Jterms where they shouldn't, which could mislead readers about the structure of Fq6 coefficients in normalized Fp12 representation.Solution
Fixed three issues in the
chunk_dense_dense_mulsection:.Jfrom the formulae = (c+d)/(1+cd*V)(line 72).Jfrom the verification equatione*(1+cd*V) == (c+d)(line 75)e, not by inputc(line 78)The formulas now correctly reflect that
eis an Fq6 coefficient, not an Fp12 element.