[Zellic Audit] 3.12 Incomplete handling of G1 point addition#379
Merged
Hakkush-07 merged 5 commits intoBitVM:mainfrom Nov 11, 2025
Merged
[Zellic Audit] 3.12 Incomplete handling of G1 point addition#379Hakkush-07 merged 5 commits intoBitVM:mainfrom
Hakkush-07 merged 5 commits intoBitVM:mainfrom
Conversation
ec5b931 to
eb11d61
Compare
eigmax
reviewed
Oct 5, 2025
29208fa to
4f8cc34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a different version of G1Affine::hinted_check_add.
To achieve this, I added Fq::equal_keep_elements() function that simply checks equality without consuming the elements.
We continue to use the version that excludes these cases, because they do not occur currently.
Edit: Newly added function is optimized from 618763 to 481633 bytes. It now merges the same operations for doubling and adding. And a TODO is added to hints in this function so that later we must add hint validity checks.
closes #302