fix: correct u8_add modulo 256 calculation#321
Open
MozirDmitriy wants to merge 1 commit intoBitVM:mainfrom
Open
fix: correct u8_add modulo 256 calculation#321MozirDmitriy wants to merge 1 commit intoBitVM:mainfrom
MozirDmitriy wants to merge 1 commit intoBitVM:mainfrom
Conversation
sander2
suggested changes
Aug 14, 2025
Contributor
sander2
left a comment
There was a problem hiding this comment.
I don't think this change is correct. I think the op_0 is needed because of the op_drop below. If you remove it, the op_drop would drop the output value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logical error in u8_add() function where OP_0 was incorrectly used
instead of proper modulo 256 calculation.
The function now correctly implements (a + b) % 256 by:
This ensures proper u32 addition behavior when handling byte-level
arithmetic operations.