Merged
Conversation
eigmax
reviewed
Aug 18, 2025
eigmax
reviewed
Aug 18, 2025
eigmax
approved these changes
Aug 23, 2025
…n terms of Fq, and fix tests for bigint change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.1: BigIntImpl::limb_from_bytes and BigIntImpl::from_bytes functions are simply unused. I removed them.
3.2: limb_to_le_bits_toaltstack function considers the case when n_bits=1 and n_bits=0, suggested solution.
3.3, 3.5: double_allow_overflow functions now expects the reference in BigInt units as in other functions, also hardcoded "9" is fixed.
3.4: I added an assertion to BigIntImpl struct that makes sure N_LIMBS is at least 2.
3.6: make sure most significant 1 lies inside the limits.
3.7: incorrect powers of two for n<7, although we dont encounter this case, is fixed by applying the suggested.
3.8: Bigint mul is simply unused. I removed it.
3.9: applied the suıggested solution.
3.10: u4_add_tables optimization is implemented and necessary hardcoded table size counts are updated.