Refactor the new distribution test#92
Merged
Merged
Conversation
1. Convert several serial loops to do concurrent. 2. Collapse array statements. 3. Associate runtime constants. 4. Use garden's assert_equals_within_absolute. 5. Move sim_speeds logic to internal pure function.
use the count() intrinsic function to convert the distribution calculation into a concurrent loop
This commit collapses the vel calcuation to 1 array statement.
This commit defines a new output_t typ and moves the build_distribution type-bound function to this new type, where it can get the empirical distribution from the copy of the input stored as a component of output_t.
1. Rename function build_distribution -> simulated_distribution. 2. Let simulated_distribution use the output_t history_ component. This eliminates all arguments required by this function except the passed-object dummy argument "self".
davytorres
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A candidate replacement for PR #91, this new PR
output_ttype that captures input/output pairs with the output being the history array.build_distributiontosimuliated_distributionbound to the new type.doloopsconcurrent.output_tobject in the main application.speedandfreqto distribution array subscripts.sim_speedscalculation into a pure function.