Skip to content

Add refactored unit and integrations tests #141

Merged
Dominick99 merged 10 commits into
mainfrom
carnivore
Jun 1, 2023
Merged

Add refactored unit and integrations tests #141
Dominick99 merged 10 commits into
mainfrom
carnivore

Conversation

@Dominick99

Copy link
Copy Markdown
Member

No description provided.

@Dominick99 Dominick99 requested a review from rouson April 25, 2023 19:41

@rouson rouson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson

rouson commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

@Dominick99 I just noticed that there's one test failing. Let me know if you'd like to look at it with me today. We should also define an integretion_test_m.f90, which we might consider namingmatcha_test_m.f90because an integration test tests the matcha application. The new test would contain the tests that are currently in the refactor/ subdirectory but not included in the new file that you created. Once the new matcha_test_m.f90 has been written, we can delete the refactor/ subdirectory and remove the garden dependency in the fpm.toml manifest.

@rouson rouson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson

rouson commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

@Dominick99 thanks for pushing the fix. Now that the test pass, feel free to merge this and create a new pull request for the integration tests or push those and merge afterward -- whichever you prefer.

@Dominick99

Dominick99 commented Apr 28, 2023

Copy link
Copy Markdown
Member Author

@rouson I just read your comment after I pushed the integration test changes to this branch, but creating a new pull request probably would have been the better way to go. Before I merge this branch, I realize something may not be correct with the how I edited the compare_global_distribution function. Originally, result_t was either a logical or a string. The way I edited the function, we return a logical test_passes, but on line 92 I replaced result_t with a print statement if it returns a string, but I realize this may not be correct because I don't know what the function is returning when this is the case. Originally, this line was result_t = succeed("compare_global_distributions") I believe it's a success message correct? If so, then the function should return true correct?

@Dominick99 Dominick99 changed the title Added test to check that cells are distributed across images Add refactored unit and integrations tests Apr 28, 2023
@rouson

rouson commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

@Dominick99 surprisingly, now there's a different test failing when the CI tests run. We can investigate this tomorrow.

@Dominick99 Dominick99 merged commit 9f4f3b2 into main Jun 1, 2023
@Dominick99 Dominick99 deleted the carnivore branch June 1, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants