feature: Thankyou page linked to routes#128
Conversation
|
the answer to this is what I was just working on now 😄 please check solution in #129 |
|
I have now created a route for this in the other PR..so the code can be copy+pasted |
danielhalasz
left a comment
There was a problem hiding this comment.
works perfectly, great job!
|
just not sure why your PR has so many changed files..have you tried merging the main branch before sending the PR? |
There was a problem hiding this comment.
Hi @Mika215 ! Thank you for your contribution and for your speed, it's impressing! The page looks great, and I am happy to see that everything works with routes.
Just a few notes:
- when I open the page in Safari, the button looks big and rather ugly 😄 (all is fine in Chrome), could you please check it and figure out? ...
- in both browsers, the size of the logo, the font and the button is very big, so that the user needs to scroll to see everything (even with a smaller footer!) Or is it just me. Maybe it could be a bit more compact? 🤔
|
Actually, when you hover the button in Safari, it just gets bigger ... and then bigger ... and then bigger! Until it takes the biggest part of the screen 😄 |
|
Hey Team, Desktop 1240pxl Tablet 768pxl Mobile 320pxl |
|
hi @Mika215 thank you it looks much better! Thanks for beginning work on the media queries too. |
|
@Mika215 check if you agree with the centering..thank you |
!!! DO not MERGE This!
Hello team i have created the "Thank you component" and tried to integrate it to the main page.
However as i can see from the Figma design @WalterAlvar @Dabrytskaya its rather supposed to be a separate page(
header,``thankyou componentandfooter).But i have no idea how i can create a separate page with vue. I am guessing that we can have only one
app.vue .i would appreciate if you could give me some directions if not i am going to try to find a solution tomorrow.