Exclude create methods from method name must contain file name - #529
Merged
IsakNaslundBh merged 2 commits intoSep 17, 2025
Conversation
Contributor
Author
|
@BHoMBot check copyright-compliance |
Contributor
Author
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 215 requests in the queue ahead of you. |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 216 requests in the queue ahead of you. |
adecler
approved these changes
Sep 17, 2025
adecler
left a comment
Member
There was a problem hiding this comment.
Happy to approve based on code review and discussion we had in a call
IsakNaslundBh
deleted the
Test_Toolkit-#528-ExcludeCreateMethodsFromMethodNameMustContainFileName
branch
September 17, 2025 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #528
Rule out create methods from requiring to be following the "Method name must match file name" contention.
See https://github.com/BHoM/BHoM_Engine/runs/50568324737 for when this is causing an issue.
Create method compliance to be improved at some point in:
#530
Test files
Changelog
Additional comments