Merge pull request #93 from Azure/azuresovereigncloud#94
Merged
arjgupta merged 5 commits intoDec 31, 2020
Merged
Conversation
GitHub Actions Beta Preview for deploying to Azure Stack Hub
asranja
reviewed
Dec 31, 2020
| required: false | ||
| default: false | ||
| environment: | ||
| description: 'Name of the environment. Supported values are azurecloud, azurestack, azureusgovernment, azurechinacloud, azuregermancloud. Default being azurecloud' |
Contributor
There was a problem hiding this comment.
casing in description doesnt match the defaultValue's casing.
asranja
reviewed
Dec 31, 2020
| if (scheme === Constants.ServicePrincipal) { | ||
| if (args.environment.toLowerCase() == "azurestack") { | ||
| command += `Add-AzEnvironment -Name ${args.environment} -ARMEndpoint ${args.resourceManagerEndpointUrl} | out-null;`; | ||
| } |
asranja
reviewed
Dec 31, 2020
| } | ||
|
|
||
| // Attempting Az cli login | ||
| if (environment == "azurestack") { |
Contributor
There was a problem hiding this comment.
we could have a utility for azure stack
Contributor
Author
There was a problem hiding this comment.
I cannot do anything for this now. these changes are already in master. I'll add a todo and leave it for later.
asranja
approved these changes
Dec 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions Beta Preview for deploying to Azure Stack Hub