Skip to content

Remove HttpClient auto-instrumentation from azsdk-cli telemetry pipeline#16452

Open
praveenkuttappan with Copilot wants to merge 1 commit into
mainfrom
copilot/remove-httpclientinstrumentation
Open

Remove HttpClient auto-instrumentation from azsdk-cli telemetry pipeline#16452
praveenkuttappan with Copilot wants to merge 1 commit into
mainfrom
copilot/remove-httpclientinstrumentation

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

azsdk-cli was registering HttpClient OpenTelemetry instrumentation, which is no longer desired in this telemetry path. This change removes that registration while leaving the rest of the tracing/export pipeline intact.

  • What changed

    • Removed AddHttpClientInstrumentation() from telemetry tracer setup in TelemetryRegistration.
    • Kept existing activity source registration and TelemetryProcessor wiring unchanged.
  • Impact

    • Outbound HttpClient dependency spans are no longer auto-collected by azsdk-cli telemetry registration.
    • CLI/MCP telemetry flow remains based on explicit tool activity sources and current processors/exporters.
  • Code change (excerpt)

builder.AddSource(Constants.TOOLS_ACTIVITY_SOURCE)
    .AddProcessor(new TelemetryProcessor());

Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Copilot AI changed the title Remove HttpClient instrumentation from azsdk-cli telemetry Remove HttpClient auto-instrumentation from azsdk-cli telemetry pipeline Jul 22, 2026
Copilot AI requested a review from praveenkuttappan July 22, 2026 19:34
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
61 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@praveenkuttappan
praveenkuttappan marked this pull request as ready for review July 22, 2026 21:36
@praveenkuttappan
praveenkuttappan requested a review from a team as a code owner July 22, 2026 21:36
Copilot AI review requested due to automatic review settings July 22, 2026 21:36
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
65 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes HttpClient OpenTelemetry auto-instrumentation from azsdk-cli’s telemetry registration so dependency spans from outbound HTTP calls are no longer automatically collected, while keeping the existing tracing pipeline (activity source + processor + exporters) intact.

Changes:

  • Removed AddHttpClientInstrumentation() from the OpenTelemetry tracing builder chain.
  • Kept the explicit activity source registration (Constants.TOOLS_ACTIVITY_SOURCE) and TelemetryProcessor wiring unchanged.

@praveenkuttappan
praveenkuttappan enabled auto-merge (squash) July 22, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants