Enhance configuration diff with previous values for modified kvs #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2026 11:24
jimmyca15
reviewed
Feb 9, 2026
| existing: ConfigurationSetting<string>; | ||
| } | ||
|
|
||
| export interface ConfigurationChanges { |
Member
There was a problem hiding this comment.
This is a bit of an odd way to represent this. Ideally, there should be one type perhaps ConfigurationSettingChange
ConfigurationSettingChange {
changeType: Enum [Create, Delete, Update, None],
currentValue: ConfigurationSetting,
newValue: ConfigurationSetting
}
And users can expect a simple Array<ConfigurationSettingChange>
Contributor
Author
There was a problem hiding this comment.
Makes sense. Although I am just wondering, for change types like Create, Delete and None there have no current values. It will always be empty. Will that be a bit odd?
jimmyca15
reviewed
Feb 9, 2026
| export interface ConfigurationChanges { | ||
| ToDelete: ConfigurationSetting<string>[]; | ||
| ToModify: SetConfigurationSettingParam<string | FeatureFlagValue | SecretReferenceValue>[]; | ||
| ToModify: ModifiedSetting[]; |
Member
There was a problem hiding this comment.
Given this is a public type, this will be a breaking change and that will need to be reflected in the new package version. (major version bump)
Contributor
Author
There was a problem hiding this comment.
Updated major version bump
jimmyca15
approved these changes
Feb 9, 2026
RichardChen820
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the configuration changes diff by surfacing old and new values for modified key-values, giving Copilot more complete context to perform effective risk analysis.