Merged
Conversation
jtenner
approved these changes
Aug 26, 2019
Contributor
There was a problem hiding this comment.
Personally, I'm not one for code style problems but they look fine to me. Alloc inlining already happens with binaryen, but it's fine to annotate it.
@RedDwarfian you should take a look at this.
I'll stew on this for a bit longer before pulling it, but LGTM.
Member
|
Would avoid inlining public API methods, as it might be confusing if a method one calls isn't actually present in the binary respectively does not show up in stack traces when debugging. |
Member
Author
|
@dcodeIO Yeah, makes sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.