Skip to content

[Implement] Buffer Read/Write 32 Bit Int/Float#19

Merged
jtenner merged 7 commits intoAssemblyScript:masterfrom
RedDwarfian:buffer-i32
Aug 6, 2019
Merged

[Implement] Buffer Read/Write 32 Bit Int/Float#19
jtenner merged 7 commits intoAssemblyScript:masterfrom
RedDwarfian:buffer-i32

Conversation

@RedDwarfian
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@jtenner jtenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks excellent now.

@dcodeIO?

@MaxGraey
Copy link
Copy Markdown
Member

MaxGraey commented Aug 1, 2019

It seems this PR miss readDoubleLE/readDoubleBE and writeDoubleLE/writeDoubleBE?

@jtenner
Copy link
Copy Markdown
Contributor

jtenner commented Aug 2, 2019

He told me he wanted to cover the 32 bit operations in this pull request. He already started work on those functions elsewhere.

@MaxGraey
Copy link
Copy Markdown
Member

MaxGraey commented Aug 2, 2019

Got it

Copy link
Copy Markdown
Contributor

@jtenner jtenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick.

if (i32(offset < 0)... 

Can we put a space between the if and each parenthesis in the assembly/buffer/index.ts file?

Once this is done, I'll pull the request.

@MaxGraey
Copy link
Copy Markdown
Member

MaxGraey commented Aug 6, 2019

LGTM

@jtenner jtenner merged commit f1056aa into AssemblyScript:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants