Fixed stdlib builtins not working with typedoc#1894
Merged
Conversation
Member
|
Hmm, interesting. Unreachable is currently typed as declare function unreachable(): never;and in AS itself is an expression of any type. I guess the following doesn't work either? static new(value: i32): i31ref { return <i31ref>unreachable(); }
static get(i31expr: i31ref): i32 { return <i32>unreachable(); }Ah, I see now. In this particular file, it picks up the AS-internal builtin definition of // @ts-ignore: decorator
@unsafe @builtin
export declare function unreachable(): void;Changing the static new(value: i32): i31ref { return changetype<i31ref>(unreachable()); }
static get(i31expr: i31ref): i32 { return unreachable(); }Wondering if that would be a preferable fix? (other than that it's kinda hilarious where just naming an instruction |
Contributor
Author
dcodeIO
approved these changes
Jun 9, 2021
Contributor
Author
torch2424
added a commit
that referenced
this pull request
Jun 16, 2021
torch2424
added a commit
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hello!
This is just something I noticed when working on the Fastly AS SDK.
It seems like in version
0.18.13, we introduced a change in which caused a type error, as we try to assignvoidto ani32, andi31ref:I got the error above when running typedoc on version
0.19.1, but it works again on0.18.12. So, I assume unreachable is the instruction that causes things to crash. So instead of returning void, I still call the function, but return a "void number" (0), which I assume is the expected behavior?With this fix, things start working again in the type system:
Thanks to whoever picks up this review! 😄 🎉
cc @dcodeIO @MaxGraey 😄